Cleanup from readthough #1241
Closed
Cleanup from readthough #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,4 +31,4 @@ dramatically. | |||
|
|
|||
| Michael R. Crusoe took over maintainership June, 2013. | |||
|
|
|||
| MRC 2015-07-31 | |||
| Last updated by MRC on 2015-07-31 | |||
There was a problem hiding this comment.
Did we want to expand this section to include all other contributors? I assume not, but it might be worth distinguishing between contributours here and authors elsewhere
| normalize-by-median.py [ ... ] --savetable file1.ct file1.fa | ||
| normalize-by-median.py [ ... ] --loadtable file1.ct --savetable file2.ct file2.fa | ||
| normalize-by-median.py [ ... ] --loadtable file2.ct --savetable file3.ct file3.fa | ||
| normalize-by-median.py [ ... ] --savegraph file1.ct file1.fa |
There was a problem hiding this comment.
so, turns out, in the codebase this is "savetable" and it's in a few hundred locations.
Are we gonna change all of the stuff in the codebase to loadgraph?
There was a problem hiding this comment.
That should have happened already.
| Stein, Susan Steinman, Benjamin Taylor, C. Titus Brown, Will Trimble, | ||
| Connor T. Skennerton, Michael Wright, Brian Wyss, Qingpeng Zhang, en | ||
| zyme, C. Titus Brown | ||
|
|
|
retest this please |
Conflicts: Makefile doc/contributors.rst doc/index.rst lib/kmer_hash.cc lib/kmer_hash.hh sandbox/collect-reads.py sandbox/correct-reads.py sandbox/estimate_optimal_hash.py sandbox/saturate-by-median.py sandbox/sweep-files.py sandbox/sweep-reads.py scripts/abundance-dist-single.py scripts/count-overlap.py scripts/do-partition.py scripts/filter-abund-single.py scripts/filter-abund.py scripts/find-knots.py scripts/interleave-reads.py scripts/load-into-countgraph.py scripts/make-initial-stoptags.py scripts/normalize-by-median.py scripts/split-paired-reads.py scripts/trim-low-abund.py setup.py tests/test_countgraph.py tests/test_scripts.py
|
retest this please |
|
retest this please |
Conflicts: doc/user/known-issues.rst
|
retest this please |
|
retest this please |
|
@mr-c Ready for CR/merge (though this PR thinks it's going to doc/frenzy, so might need a manual pull into master) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.