Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added epilog documentation for <base>.dist file produced by extract-part... #516

Merged
merged 2 commits into from
Jul 1, 2014
Merged

added epilog documentation for <base>.dist file produced by extract-part... #516

merged 2 commits into from
Jul 1, 2014

Conversation

chuckpr
Copy link
Contributor

@chuckpr chuckpr commented Jun 30, 2014

...itions.py

Included info for the .dist file columns produced by extract-partitions.py in the epilog for extract-partitions.py.

  • Is it mergable
  • Did it pass the tests?
  • [N/A] If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • Is it documented in the Changelog?
  • Was spellcheck run on the source code and documentation after changes
    were made?

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@mr-c
Copy link
Contributor

mr-c commented Jun 30, 2014

ok to test

@mr-c
Copy link
Contributor

mr-c commented Jun 30, 2014

Thanks!

@mr-c mr-c closed this Jun 30, 2014
@chuckpr chuckpr deleted the partition-size-dist-doc branch June 30, 2014 21:17
@chuckpr chuckpr restored the partition-size-dist-doc branch June 30, 2014 21:18
@chuckpr
Copy link
Contributor Author

chuckpr commented Jul 1, 2014

I thought I'd give it a shot. Is there a better location for this info? It seems kind of trivial but would have been handy to me when I was making some histograms after from the .dist files.

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@mr-c
Copy link
Contributor

mr-c commented Jul 1, 2014

This was the correct location. I've already merged in your additions. Thanks again!

mr-c added a commit that referenced this pull request Jul 1, 2014
added epilog documentation for <base>.dist file produced by extract-part...
@mr-c mr-c merged commit c268b03 into dib-lab:master Jul 1, 2014
@chuckpr chuckpr deleted the partition-size-dist-doc branch July 13, 2014 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants