Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spelling fixes #867

Merged
merged 2 commits into from
Apr 4, 2015
Merged

spelling fixes #867

merged 2 commits into from
Apr 4, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Mar 11, 2015

No description provided.

@mr-c
Copy link
Contributor Author

mr-c commented Mar 30, 2015

@ctb Do we want a ChangeLog for spelling fixes?

@ctb
Copy link
Member

ctb commented Mar 30, 2015

On Mon, Mar 30, 2015 at 07:02:55AM -0700, Michael R. Crusoe wrote:

@ctb Do we want a ChangeLog for spelling fixes?

If they're only in the ChangeLog, no. Otherwise, yes.

@ctb
Copy link
Member

ctb commented Mar 30, 2015 via email

@mr-c
Copy link
Contributor Author

mr-c commented Mar 30, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c
Copy link
Contributor Author

mr-c commented Mar 30, 2015

@ctb ready for review & merge

@ctb
Copy link
Member

ctb commented Mar 31, 2015

Thanks!

@ctb
Copy link
Member

ctb commented Mar 31, 2015

Go ahead and merge it once it's mergeable.

mr-c added a commit that referenced this pull request Apr 4, 2015
@mr-c
Merge pull request #867 from ged-lab/fix/spelling
a0c2d1d 
spelling fixes
@mr-c mr-c merged commit a0c2d1d into master Apr 4, 2015
@mr-c mr-c deleted the fix/spelling branch April 4, 2015 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-c @ctb