- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the postgres multirange type #4159
Conversation
5eed8e3
to
13b453a
Compare
13b453a
to
b0ff4ed
Compare
Tests fail on Windows because the minimum version for multirange is postgres 14, released on 09/2021, and windows install postgres 12 The other failures are related to the proptest
I'm not sure how the protest for And
I don't have any idea why it fails but I would guess that is a db error again |
For the windows CI error: Sounds like we just need to install a newer Postgres version there. It's fine to include that as part of the PR. For the proptest error: I'm not at my computer but I will have a look in the next days and see what von be done there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR. That's really helpful work 🙏
I have some small note about the ToSql
implementation + a minor question. Otherwise I would like to see an Changelog.md
entry for this, as this is a relevant new feature. Otherwise this should be fine to merge.
This PR implements the Postgres multirange types