Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements std::ops::Range to Multirange toSql #4182

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

guissalustiano
Copy link
Contributor

@guissalustiano guissalustiano commented Aug 18, 2024

Implements #4112 for #4159

Unfortunately It doesn't allow diferente types in the same vec, e.g. vec![..0, 4..7, 9..]

Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good for me 👍

Unfortunately It doesn't allow diferente types in the same vec, e.g. vec![..0, 4..7, 9..]

We might be able to somewhat workaround that by allowing Box<dyn RangeBounds<T>> and/or &dyn RangeBounds<T> as types there as well. That should allow at least to write vec![Box::new(..0), Box::new(4..7), Box::new(9..)] to represent these different types.

@weiznich weiznich added this pull request to the merge queue Aug 23, 2024
Merged via the queue into diesel-rs:master with commit 81c8f3c Aug 23, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants