Extend range functions to support nullable and multirange #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guissalustiano
force-pushed
the
multirange_functions
branch
from
838fd7d to
eeaa1ad
Compare
weiznich
requested changes
Aug 23, 2024
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| #[cfg(feature = "postgres_backend")] | ||
| fn range_merge<T1: RangeHelper, T2: RangeHelper<Inner = T1::Inner>>(lhs: T1, rhs: T2) -> Range<T1::Inner>; | ||
| #[sql_name = "range_merge"] | ||
| fn multirange_merge<R: MultirangeOrNullableMultirange + SingleValue>(multirange: R) -> R::Range; |
There was a problem hiding this comment.
We need to add a helper type definition for this new function + a test variant in the #[auto_type] test case module.
There was a problem hiding this comment.
Thanks! for the review. I updated that.
guissalustiano
force-pushed
the
multirange_functions
branch
from
b9202d8 to
36a76a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the range functions to suportt multirange and nullable types, folowing the behavior of the postgres functions
Please review after #4182 and #4179 be merged