Remove embed_migrations! temporarily
#469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review? @diesel-rs/contributors |
sgrif
force-pushed
the
sg-remove-embed-associations
branch
from
d49cf44
to
2045662
Compare
|
So, the 0.8 announcement should probably mention that people using CI failure is because of |
sgrif
force-pushed
the
sg-remove-embed-associations
branch
from
2045662
to
c8b1f3a
Compare
Unfortunately it will be impossible to write this macro using the Macros 1.1 API. While this is an important feature that I want to keep, I more importantly want to keep the main repository working on stable. It will have to live as a separate crate, and possibly have an API change to work around build scripts.
sgrif
force-pushed
the
sg-remove-embed-associations
branch
from
c8b1f3a
to
250b445
Compare
|
Fixed those failures, but now seeing a really cryptic message from Cargo about path overrides doing things incorrectly. We've also got the rustc-macro -> proc-macro rename landing tonight so I'm going to wait until tomorrow to figure this out |
|
And there's more dead code to remove |
We appear to no longer be able to use `paths =` from `.cargo/config`, as it blows up when the dependencies of the overriden crate differ from the released version. This unfortunately means that we'll need to manually specify the overrides in every single one of our crates for development on master. Hopefully we can have a better solution long term, in the mean time this is the only option that will compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it will be impossible to write this macro using the Macros
1.1 API. While this is an important feature that I want to keep, I more
importantly want to keep the main repository working on stable. It will
have to live as a separate crate, and possibly have an API change to
work around build scripts.