Implement embed_migration! using macros 1.1 #470
Conversation
weiznich
force-pushed
the
embedded_migrations
branch
from
b647781
to
83411c2
Compare
weiznich
force-pushed
the
embedded_migrations
branch
4 times, most recently
from
b31f36a
to
de5c671
Compare
|
Travis is failing while building compilertest. Any idea why? |
|
Sorry, I haven't had time to look at this so far :( The CI error is because this compiles compiletest 0.2.4 which expects a nightly from 2026-10-07 (see Manishearth/compiletest-rs#50; we use 2016-09-29). You probably need to change the dependency to |
weiznich
force-pushed
the
embedded_migrations
branch
from
de5c671
to
c96dc39
Compare
|
Using compiletest 0.2.3 didn't fix this. |
| @@ -6,4 +6,4 @@ authors = ["Sean Griffin <sean@seantheprogrammer.com>"] | |||
| [dependencies] | |||
| diesel = { version = "0.7.1", features = ["sqlite", "postgres"] } | |||
| diesel_codegen = { version = "0.7.2" } | |||
| compiletest_rs = "0.2.1" | |||
| compiletest_rs = "0.2.3" | |||
There was a problem hiding this comment.
You need to write compiletest_rs = "=0.2.3" with the = before the version number or Cargo will treat this as ^0.2.3.
There was a problem hiding this comment.
Thanks, didn't know about this one.
* port embed_migration to macros 1.1 * remove codegen_old * some minor fixes
weiznich
force-pushed
the
embedded_migrations
branch
from
c96dc39
to
88c5f7a
Compare
|
Can you submit the API change as a separate PR without re-implementing it? That will make it much easier to review. |
|
I'm wanting to release today, so in order to make sure things move quickly I'm going to go ahead and take over here and make the changes I'd like to see (and split up the PR into smaller commits). I'll make sure you're credited on the commits that go in. |
This is a breaking change, because the root path passed to
embed_migrations!have changed. It's now CARGO_MANIFEST_HOME, but was before the location of the file that called that macro.