Resolve paths given to embed_migrations as relative to Cargo.toml
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@killercup Got time for a review? |
Macros 1.1 does not give us any way to access the file the macro was invoked from. In order to make the API compatible with this new system, we instead resolve paths given as relative to the only stable path we have access to, which is the location of Cargo.toml. Since it is somewhat common for people to place their migrations in `src/migrations`, we will continue to search that path if no specific path is given. However, we will no longer find paths such as `src/foo/migrations`.
sgrif
force-pushed
the
sg-embed-migrations-relative-to-cargo-toml
branch
from
d504707
to
fe01319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros 1.1 does not give us any way to access the file the macro was
invoked from. In order to make the API compatible with this new system,
we instead resolve paths given as relative to the only stable path we
have access to, which is the location of Cargo.toml. Since it is
somewhat common for people to place their migrations in
src/migrations, we will continue to search that path if no specificpath is given. However, we will no longer find paths such as
src/foo/migrations.This is based on code from #470, and I've committed as the author of that PR to ensure @weiznich is credited.