Skip to content

CI: Ubuntu 20.04 -> 24.04 #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

CI: Ubuntu 20.04 -> 24.04 #1017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/pull-request-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:

jobs:
# This job takes approximately 15 minutes
check-ubuntu-20_04-make-gcc:
runs-on: ubuntu-20.04
check-ubuntu-24_04-make-gcc:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -28,10 +28,10 @@ jobs:
with:
path: .ccache
save-always: true
key: ${{ runner.os }}-20.04-make-gcc-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-make-gcc-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-make-gcc-${{ github.ref }}
${{ runner.os }}-20.04-make-gcc
${{ runner.os }}-24.04-make-gcc-${{ github.ref }}
${{ runner.os }}-24.04-make-gcc
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down Expand Up @@ -62,8 +62,8 @@ jobs:
run: ccache -s

# This job takes approximately 15 minutes
check-ubuntu-20_04-make-clang:
runs-on: ubuntu-20.04
check-ubuntu-24_04-make-clang:
runs-on: ubuntu-24.04
env:
CC: "ccache clang"
CXX: "ccache clang++"
Expand All @@ -78,7 +78,7 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -yq clang-10 clang++-10 gdb jq flex bison libxml2-utils cpanminus ccache z3
sudo apt-get install --no-install-recommends -yq clang-19 clang++-19 gdb jq flex bison libxml2-utils cpanminus ccache z3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should now just be clang and clang++ instead of using a particular version of the compiler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first attempt -- apt-get install errors.

cpanm Thread::Pool::Simple
- name: Confirm z3 solver is available and log the version installed
run: z3 --version
Expand All @@ -87,10 +87,10 @@ jobs:
with:
path: .ccache
save-always: true
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-PR
key: ${{ runner.os }}-24.04-make-clang-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
${{ runner.os }}-24.04-make-clang-${{ github.ref }}
${{ runner.os }}-24.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand Down Expand Up @@ -134,8 +134,8 @@ jobs:

# This job takes approximately 4 minutes
benchmarking:
runs-on: ubuntu-20.04
needs: check-ubuntu-20_04-make-clang
runs-on: ubuntu-24.04
needs: check-ubuntu-24_04-make-clang
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -162,8 +162,8 @@ jobs:

# This job takes approximately 1 minute
examples:
runs-on: ubuntu-20.04
needs: check-ubuntu-20_04-make-clang
runs-on: ubuntu-24.04
needs: check-ubuntu-24_04-make-clang
steps:
- uses: actions/checkout@v4
- name: Get the ebmc binary
Expand Down
Loading