- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
          remove .coveragerc file
          #58
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
+ Coverage   69.85%   93.49%   +23.63%     
===========================================
  Files           3        4        +1     
  Lines         345      169      -176     
===========================================
- Hits          241      158       -83     
+ Misses        104       11       -93      | 
| This isn't passing after I made a second push, similar to the other PR here #55 Edit: Looks like this is an active issue faced by others. I've created an issue for this. Solution is being worked out here but will look into this: codecov/codecov-action#1580 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is better without a news. Delete the news.
| @cadenmyers13 also, this is failing tests. Some issue with codecov | 
| Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, | 
| @sbillinge Yeah... there's a github thread here discussing it: codecov/codecov-action#1580 | 
| Thanks @cadenmyers13 Looks like the codecov problem is resolved too! | 
closes #57. With
testsat top level, we no longer need to omit any files aspytestautomatically detects files intests. scikit-package/scikit-package#177 (comment)