Skip to content

Conversation

@bobleesj
Copy link
Collaborator

@bobleesj bobleesj commented Nov 2, 2024

Closes #176

target: auto # use the coverage from the base commit, fail if coverage is lower
threshold: 0% # allow the coverage to drop by

comment:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the doc recommended setup

Ref: https://docs.codecov.com/docs/pull-request-comments

Copy link
Collaborator Author

@bobleesj bobleesj Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the tests folder separated, pytest automatically detects all files within tests. So we do not need to omit files outside of tests.

@bobleesj bobleesj marked this pull request as ready for review November 2, 2024 00:36
@bobleesj
Copy link
Collaborator Author

bobleesj commented Nov 2, 2024

@sbillinge ready for review. Will test using diffpy.snmf

@sbillinge sbillinge merged commit 0d97b2a into scikit-package:main Nov 5, 2024
1 check passed
@bobleesj bobleesj deleted the codecov-pr branch November 7, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add codecov posting of coverage on each PR (cookiecutting standard)

2 participants