Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color warnings for the themebuilder #2323

Closed
Thunear opened this issue Aug 26, 2024 · 0 comments · Fixed by #2333
Closed

Improve color warnings for the themebuilder #2323

Thunear opened this issue Aug 26, 2024 · 0 comments · Fixed by #2333
Assignees
@Thunear
Labels
🎨 theme-builder Everything related to our theme builder
Milestone
Helhetlig tematis...

Comments

@Thunear
Copy link
Collaborator

Thunear commented Aug 26, 2024 •
edited
Loading

Improve the warning system for the colors and create documentation on how to use the tool.

  • Simplify the color warning system to only show 3:1 warning against background colors
    • Removed the color warning that said that the contrast color did not have good enough contrast against all the base colors. This has been fixed in the tool.
  • Add documentation page that explains how to use the tool and how to pick the colors

Can be tested here: https://pr-2333.theme.designsystemet.no/
@Thunear Thunear self-assigned this Aug 26, 2024
@Thunear Thunear converted this from a draft issue Aug 26, 2024
@Thunear Thunear added the 🎨 theme-builder Everything related to our theme builder label Aug 26, 2024
@mrosvik mrosvik changed the title Add new color warnings and get started documentation Improve insufficient contrast warning in Theme builder Sep 19, 2024
@mrosvik mrosvik added this to the V1 - Helhetlig tematisering milestone Sep 19, 2024
@mrosvik mrosvik mentioned this issue Sep 19, 2024
Closed
@mimarz mimarz mentioned this issue Sep 19, 2024
Closed
@Thunear Thunear changed the title Improve insufficient contrast warning in Theme builder Improve color warnings for the themebuilder Oct 15, 2024
@Thunear Thunear mentioned this issue Oct 16, 2024
Merged
Thunear added a commit that referenced this issue Oct 18, 2024
@Thunear @Barsnes
chore: simplify color warnings and other fixes for themebuilder (#2333)
9bbbe98 
resolves #2323

Also some other fixes:
* Add footer
* Fix the header and text inside the color modal.
* Styling fixes on the component preview
* Hide contrast and border radius selects until these are functional in
both code and figma

---------

Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunear Thunear

Labels
🎨 theme-builder Everything related to our theme builder
Projects
Team Design System
Status: ✅ Done
Milestone
Helhetlig tematisering
Development

Successfully merging a pull request may close this issue.

chore: simplify color warnings and other fixes for themebuilder digdir/designsystemet
2 participants
@mrosvik @Thunear