Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify color warnings and other fixes for themebuilder #2333

Merged
merged 24 commits into from
Oct 18, 2024
Merged

chore: simplify color warnings and other fixes for themebuilder #2333

merged 24 commits into from
Oct 18, 2024

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented Aug 27, 2024 •
edited
Loading

resolves #2323

Also some other fixes:

  • Add footer
  • Fix the header and text inside the color modal.
  • Styling fixes on the component preview
  • Hide contrast and border radius selects until these are functional in both code and figma

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3bb9dc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Thunear Thunear self-assigned this Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 18. Oct 2024 - 12:10

Storefront - 18. Oct 2024 - 12:11

Theme - 18. Oct 2024 - 12:11

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 57.58% 3556 / 6175
🔵 Statements 57.58% 3556 / 6175
🔵 Functions 84.65% 160 / 189
🔵 Branches 76.48% 501 / 655
File CoverageNo changed files found.
Generated in workflow #420 for commit 3bb9dc3 by the Vitest Coverage Report Action

@Thunear Thunear changed the title chore: add Get Started documentation and add new color warning system chore: simplify color warnings and other fixes Oct 15, 2024
@Thunear Thunear changed the title chore: simplify color warnings and other fixes chore: simplify color warnings and other fixes for themebuilder Oct 15, 2024
@Barsnes Barsnes mentioned this pull request Oct 17, 2024
Merged
@Thunear Thunear marked this pull request as ready for review October 17, 2024 11:06
Barsnes
Barsnes reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/user-attachments/assets/3058a10c-3cd4-44e4-977d-fb04c6ee24db
Can we add a min-height of 100vh?

apps/theme/app/slik-bruker-du-verktoyet/page.tsx Show resolved Hide resolved
apps/theme/public/img/1080p.jpg Outdated Show resolved Hide resolved
apps/theme/public/img/test.png Outdated Show resolved Hide resolved
apps/theme/public/img/test2.png Outdated Show resolved Hide resolved
@Thunear Thunear merged commit 9bbbe98 into next Oct 18, 2024
8 checks passed
@Barsnes Barsnes deleted the chore/color-warnings branch October 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barsnes Barsnes Barsnes approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Assignees

@Thunear Thunear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve color warnings for the themebuilder
2 participants
@Thunear @Barsnes