Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraph changes for v1 #2503

Closed
3 tasks done
mimarz opened this issue Sep 24, 2024 · 1 comment
Closed
3 tasks done

Paragraph changes for v1 #2503

mimarz opened this issue Sep 24, 2024 · 1 comment
Assignees
@Barsnes
Labels
☂️ epic Issues ready
Milestone
V1 - Lansering

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 24, 2024 •
edited by Barsnes
Loading

We agreed on daily today to simplify Paragraph and paragraph typography style.

  • Rename typography style paragraph to body
  • Remove ingress/lead - use body long instead
  • Remove short variant from Paragraph
    • Review if we still need body/paragraph short internally in the end.

Tasks
Preview Give feedback
  3. Remove ingress in figma #2528
    3 of 3
    $ tokens 🎨 figma
    Febakke
@mimarz mimarz converted this from a draft issue Sep 24, 2024
@mimarz mimarz mentioned this issue Sep 24, 2024
Closed
@mimarz mimarz added 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react ☂️ epic Issues ready and removed 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react labels Sep 24, 2024
@mimarz mimarz added this to the V1 - Helhetlig komponentbibliotek milestone Sep 24, 2024
@mimarz mimarz mentioned this issue Sep 25, 2024
Closed
@Barsnes Barsnes self-assigned this Sep 25, 2024
@Barsnes Barsnes mentioned this issue Sep 25, 2024
Merged
Barsnes added a commit that referenced this issue Sep 25, 2024
@Barsnes
feat(typography): use classes for typography styles (#2514)
aa53b02 
related to #2503

Doing everything in typography except ingress, since this will be
removed.

Spacing now has to be on every class, but we have an issue about
removing this.
We could also let it be outside the classes, since `data-spacing` is
only used for typography components, and it needs the css var to do
anything.
@Barsnes Barsnes mentioned this issue Sep 25, 2024
Merged
Barsnes added a commit that referenced this issue Sep 27, 2024
@Barsnes
feat(Ingress): remove component (#2515)
adcaece 
part of #2503 

Ingress on storeront now has wrong size, but this is noted and will be
fixed when we do a separate PR for storefront fixes.
This will not be deployed to production when merged
@Barsnes
Copy link
Member

Barsnes commented Oct 9, 2024

closing as completed

@Barsnes Barsnes closed this as completed Oct 9, 2024
@github-project-automation github-project-automation bot moved this from ☂ Epics to ✅ Done in Team Design System Oct 9, 2024
@mrosvik mrosvik modified the milestones: Helhetlig komponentbibliotek, V1 - Lansering Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Barsnes Barsnes

Labels
☂️ epic Issues ready
Projects
Team Design System
Status: ✅ Done
Milestone
V1 - Lansering
Development

No branches or pull requests
3 participants
@mimarz @mrosvik @Barsnes