-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typography): use classes for typography styles #2514
Conversation
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, back to how it was before, but hey it works 🤷♂️
This will be the only exception to use of --<size>
instead of data-size
for sizes elsewhere.
related to #2503
Doing everything in typography except ingress, since this will be removed.
Spacing now has to be on every class, but we have an issue about removing this.
We could also let it be outside the classes, since
data-spacing
is only used for typography components, and it needs the css var to do anything.