Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typography): use classes for typography styles #2514

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Sep 25, 2024

related to #2503

Doing everything in typography except ingress, since this will be removed.

Spacing now has to be on every class, but we have an issue about removing this.
We could also let it be outside the classes, since data-spacing is only used for typography components, and it needs the css var to do anything.

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 9b73fe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Preview deployments for this pull request:

Storybook - 25. Sep 2024 - 13:20

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 61.36% 4146 / 6756
🔵 Statements 61.36% 4146 / 6756
🔵 Functions 86.29% 170 / 197
🔵 Branches 75.37% 557 / 739
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/Typography/Heading/Heading.tsx 100% 100% 100% 100%
packages/react/src/components/Typography/Label/Label.tsx 100% 100% 100% 100%
packages/react/src/components/Typography/Paragraph/Paragraph.tsx 100% 83.33% 100% 100%
packages/react/src/components/Typography/ValidationMessage/ValidationMessage.tsx 100% 100% 100% 100%
Generated in workflow #20

@Barsnes Barsnes marked this pull request as ready for review September 25, 2024 11:36
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, back to how it was before, but hey it works 🤷‍♂️

This will be the only exception to use of --<size> instead of data-size for sizes elsewhere.

@Barsnes Barsnes merged commit aa53b02 into next Sep 25, 2024
8 checks passed
@Barsnes Barsnes deleted the css/typography branch September 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants