revert: remove getByDocId optional parameter
#968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56f7e18 and replaces it with an internal-only function, `getByDocIdIfExists`.
EvanHahn
force-pushed
the
getDocById-if-missing-wrapper
branch
from
34a250a
to
1a0af6d
Compare
EvanHahn
commented
Nov 18, 2024
src/datatype/index.d.ts
Outdated
Comment on lines
88
to
95
| getByDocId( | ||
| docId: string, | ||
| opts?: { mustBeFound?: true; lang?: string } | ||
| opts?: { lang?: string } | ||
| ): Promise<TDoc & { forks: string[] }> | ||
| getByDocId( | ||
| docId: string, | ||
| opts?: { mustBeFound?: boolean; lang?: string } | ||
| ): Promise<null | (TDoc & { forks: string[] })> |
There was a problem hiding this comment.
This is part of the revert.
src/datatype/index.js
Outdated
There was a problem hiding this comment.
All changes to this file are just reversions.
src/roles.js
Outdated
| mustBeFound: false, | ||
| }) | ||
| if (!roleAssignment) { | ||
| const roleRecord = await getByDocIdIfExists(this.#dataType, deviceId) |
There was a problem hiding this comment.
Not strictly related, but I renamed this to make the diff for #188 a little smaller.
test/data-type/index.js
Outdated
| * @param {object} [opts={}] | ||
| * @param {Buffer} [opts.projectKey] | ||
| */ | ||
| async function testenv(opts = {}) { |
There was a problem hiding this comment.
This was moved into a helper (see below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 56f7e18 and replaces it with an internal-only function,
nullIfNotFound.