Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: remove getByDocId optional parameter #968

Merged
merged 4 commits into from
Nov 21, 2024
Merged

revert: remove getByDocId optional parameter #968

merged 4 commits into from
Nov 21, 2024

Commits on Nov 18, 2024

  1. revert: remove getByDocId optional parameter 

    This reverts commit 56f7e18 and
replaces it with an internal-only function, `getByDocIdIfExists`.
    @EvanHahn
    EvanHahn committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1a0af6d View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. nullIfNotFound instead

    @EvanHahn
    EvanHahn committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a652b05 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into getDocById-if-missing-wrapper

    @EvanHahn
    EvanHahn committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1d9432f View commit details
    Browse the repository at this point in the history

  3. More reversions

    @EvanHahn
    EvanHahn committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7cd7e70 View commit details
    Browse the repository at this point in the history