2731: Add linting rule for arrays

[simomps]

Short description

Add a linting style for arrays

Proposed changes

• All arrays displayed as arrayName[]
• other array style changed according to new rule

Side effects

• None

Testing

Check that all settings still work.

Resolved issues

Fixes: #2731

---

[steffenkleinle]

Congrats to your first PR, nicely done 🚀 Just one small comment regarding the yarn.lock, I think this is otherwise good to go!

[steffenkleinle]

Thank you 👍

[codeclimate]

Code Climate has analyzed commit cf8c5ad and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 94.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.2%.

View more on Code Climate.

[LeandraH]

Very cool, thank you very much for cleaning up 🧽

I have found two more places where we still use the Array type, one is Selector.ts in the e2e-tests, the other one in helpers.spec.ts in native, might be worth a check why the linter doesn't find that. But then again, maybe not 😂

[LeandraH]

I'll approve it already since I'll be on vacation for a bit and don't want to block anything :)

[steffenkleinle]

Very cool, thank you very much for cleaning up 🧽

I have found two more places where we still use the Array type, one is Selector.ts in the e2e-tests, the other one in helpers.spec.ts in native, might be worth a check why the linter doesn't find that. But then again, maybe not 😂

Actually I am quite sure that this is something different. The two occurrences mentioned by you are both referring to
something like the following:

const keys = new Array<string>()

These are initialization of a new array instance (of type string), opposed to something like the following which actually throws an error in both cases:

const keys: Array<string> = new Array<string>()

I therefore think we are actually good to go here :)

[LeandraH]

Woooops, you're right, sorry!