2731: Add linting rule for arrays

.eslintrc.js

@@ -113,6 +113,12 @@ module.exports = {
         allowNullableString: true,
       },
     ],
+    '@typescript-eslint/array-type': [
+      'error',
+      {
+        default: 'array',
+      },
+    ],
     '@typescript-eslint/switch-exhaustiveness-check': 'error',
     '@typescript-eslint/no-non-null-assertion': 'error',
 

build-configs/BuildConfigType.ts

@@ -52,9 +52,9 @@ export type CommonBuildConfigType = {
   // Host name of the web app, used for sharing, deep linking and social media previews.
   hostName: string
   // Hostnames from which resources are automatically downloaded for offline usage.
-  allowedHostNames: Array<string>
+  allowedHostNames: string[]
   // Linked hosts that can may look similar https://chromium.googlesource.com/chromium/src/+/master/docs/security/lookalikes/lookalike-domains.md#automated-warning-removal
-  allowedLookalikes: Array<string>
+  allowedLookalikes: string[]
   // Regex defining which urls to intercept as they are internal ones.
   supportedIframeSources: string[]
   internalLinksHijackPattern: string

e2e-tests/native/test/helpers/Selector.ts

@@ -1,5 +1,5 @@
 export class Selector {
-  private queries: Array<string> = new Array<string>()
+  private queries: string[] = new Array<string>()
 
   public ByText(text: string): Selector {
     if (driver.isAndroid) {

e2e-tests/web/wdio.conf.ts

@@ -1,7 +1,7 @@
 import { browsers, ciCapabilities } from './capabilities.js'
 import waitForLocalhost from './waitForLocalhost.js'
 
-const getCapabilities = (): Array<WebdriverIO.Capabilities> => {
+const getCapabilities = (): WebdriverIO.Capabilities[] => {
   if (process.env.CI) {
     return [ciCapabilities]
   }

native/src/__mocks__/react-native-blob-util.ts

@@ -27,7 +27,7 @@ const existsMock = (file: string): Promise<boolean> => {
   return Promise.resolve(exists || isParentOfExisting)
 }
 
-const lsMock = (path: string): Promise<Array<string>> => {
+const lsMock = (path: string): Promise<string[]> => {
   const filesInPath = Object.keys(mockFiles).filter(filePath => filePath.startsWith(path))
   return Promise.resolve(filesInPath)
 }
@@ -58,7 +58,7 @@ export default {
     },
   },
   fs: {
-    ls: jest.fn<Promise<Array<string>>, [string]>(lsMock),
+    ls: jest.fn<Promise<string[]>, [string]>(lsMock),
     exists: jest.fn<Promise<boolean>, [string]>(existsMock),
     isDir: jest.fn<Promise<boolean>, [string]>(async () => true),
     writeFile: jest.fn<Promise<void>, [string, string, string]>(writeMockFile),

native/src/components/CitySelector.tsx

@@ -27,7 +27,7 @@ const SearchBar = styled.View`
 `
 
 type CitySelectorProps = {
-  cities: Array<CityModel>
+  cities: CityModel[]
   navigateToDashboard: (city: CityModel) => void
 }
 

native/src/components/CustomHeaderButtons.tsx

@@ -40,8 +40,8 @@ const onOverflowMenuPress = (cancelButtonLabel: string) => (props: OnOverflowMen
 
 const CustomHeaderButtons = (props: {
   cancelLabel: string
-  items: Array<ReactNode>
-  overflowItems: Array<ReactNode>
+  items: ReactNode[]
+  overflowItems: ReactNode[]
 }): ReactElement => {
   const { cancelLabel, items, overflowItems } = props
   const { t } = useTranslation('common')

native/src/components/List.tsx

@@ -10,7 +10,7 @@ const NoItemsMessage = styled.Text`
 `
 
 type ListProps<T> = {
-  items: Array<T>
+  items: T[]
   noItemsMessage?: ReactElement | string
   renderItem: (props: { item: T; index: number }) => ReactElement
   Header?: ReactElement

native/src/components/NearbyCities.tsx

@@ -31,7 +31,7 @@ const StyledIcon = styled(Icon)`
 `
 
 type NearbyCitiesProps = {
-  cities: Array<CityModel>
+  cities: CityModel[]
   navigateToDashboard: (city: CityModel) => void
   filterText: string
 }

native/src/components/News.tsx

@@ -37,7 +37,7 @@ const getPageTitle = (
   return t('localNews.pageTitle')
 }
 
-type NewsModelsType = Array<LocalNewsModel | TunewsModel>
+type NewsModelsType = (LocalNewsModel | TunewsModel)[]
 
 type NewsProps = {
   news: NewsModelsType

native/src/components/Selector.tsx

@@ -15,7 +15,7 @@ export const Wrapper = styled.View`
 `
 
 type SelectorProps = {
-  items: Array<SelectorItemModel>
+  items: SelectorItemModel[]
   selectedItemCode: string | null
 }
 

native/src/components/__tests__/News.spec.tsx

@@ -68,7 +68,7 @@ describe('News', () => {
     localNewsEnabled = true,
   }: {
     newsId?: number | null
-    data?: Array<LocalNewsModel | TunewsModel>
+    data?: (LocalNewsModel | TunewsModel)[]
     loadingMore?: boolean
     selectedNewsType?: TuNewsType | LocalNewsType
     tuNewsEnabled?: boolean

native/src/constants/NavigationTypes.ts

@@ -100,8 +100,8 @@ export type RoutesParamsType = {
   }
   [LICENSES_ROUTE]: undefined
   [CHANGE_LANGUAGE_MODAL_ROUTE]: {
-    languages: Array<LanguageModel>
-    availableLanguages: Array<string>
+    languages: LanguageModel[]
+    availableLanguages: string[]
   }
   [PDF_VIEW_MODAL_ROUTE]: {
     url: string

native/src/navigation/navigateToLanguageChange.ts

@@ -10,8 +10,8 @@ const navigateToLanguageChange = <T extends RoutesType>({
   availableLanguages,
 }: {
   navigation: NavigationProps<T>
-  languages: Array<LanguageModel>
-  availableLanguages: Array<string>
+  languages: LanguageModel[]
+  availableLanguages: string[]
 }): void => {
   sendTrackingSignal({
     signal: {

native/src/routes/Events.tsx

@@ -32,7 +32,7 @@ const PageDetailsContainer = styled.View`
 
 export type EventsProps = {
   slug?: string
-  events: Array<EventModel>
+  events: EventModel[]
   cityModel: CityModel
   language: string
   navigateTo: (routeInformation: RouteInformationType) => void

native/src/routes/Intro.tsx

@@ -124,7 +124,7 @@ const Intro = ({ route, navigation }: IntroProps): ReactElement => {
 
   const renderSlide = ({ item }: { item: SlideContentType }) => <SlideContent item={item} width={width} />
 
-  const onViewableItemsChanged = useCallback(({ viewableItems }: { viewableItems: Array<ViewToken> }) => {
+  const onViewableItemsChanged = useCallback(({ viewableItems }: { viewableItems: ViewToken[] }) => {
     const viewableItem = viewableItems[0]
     if (viewableItem) {
       if (viewableItem.index !== null) {

native/src/routes/Pois.tsx

@@ -46,7 +46,7 @@ const getBottomSheetSnapPoints = (deviceHeight: number): [number, number, number
 ]
 
 type PoisProps = {
-  pois: Array<PoiModel>
+  pois: PoiModel[]
   cityModel: CityModel
   language: string
   refresh: () => void

native/src/routes/SearchModal.tsx

@@ -23,7 +23,7 @@ const Wrapper = styled.View`
 `
 
 export type SearchModalProps = {
-  allPossibleResults: Array<SearchResult>
+  allPossibleResults: SearchResult[]
   languageCode: string
   cityCode: string
   closeModal: (query: string) => void

native/src/utils/AppSettings.ts

@@ -14,7 +14,7 @@ export type SettingsType = {
   apiUrlOverride: string | null
   jpalTrackingEnabled: boolean | null
   jpalTrackingCode: string | null
-  jpalSignals: Array<SignalType>
+  jpalSignals: SignalType[]
   externalSourcePermissions: ExternalSourcePermissions
 }
 export const defaultSettings: SettingsType = {

native/src/utils/DataContainer.ts

@@ -15,24 +15,24 @@ export type DataContainer = {
    * Returns an Array of PoiModels.
    * @throws Will throw an error if the array is null.
    */
-  getPois: (city: string, language: string) => Promise<Array<PoiModel>>
+  getPois: (city: string, language: string) => Promise<PoiModel[]>
 
   /**
    * Sets the pois and persist them ?
    */
-  setPois: (city: string, language: string, pois: Array<PoiModel>) => Promise<void>
+  setPois: (city: string, language: string, pois: PoiModel[]) => Promise<void>
 
   /**
    * Returns an Array of CityModels.
    * @throws Will throw an error if the array is null.
    */
-  getCities: () => Promise<Array<CityModel>>
+  getCities: () => Promise<CityModel[]>
 
   /**
    * Sets the cities but does not persist them.
    * For now switching cities when offline is not possible.
    */
-  setCities: (cities: Array<CityModel>) => Promise<void>
+  setCities: (cities: CityModel[]) => Promise<void>
 
   /**
    * Returns the CategoriesMapModel.
@@ -49,23 +49,23 @@ export type DataContainer = {
    * Returns an Array of events.
    * @throws Will throw an error if the array is null.
    */
-  getEvents: (city: string, language: string) => Promise<Array<EventModel>>
+  getEvents: (city: string, language: string) => Promise<EventModel[]>
 
   /**
    * Sets the events and persists them.
    */
-  setEvents: (city: string, language: string, events: Array<EventModel>) => Promise<void>
+  setEvents: (city: string, language: string, events: EventModel[]) => Promise<void>
 
   /**
    * Returns an Array of local news.
    * @throws Will throw an error if the array is null.
    */
-  getLocalNews: (city: string, language: string) => Promise<Array<LocalNewsModel>>
+  getLocalNews: (city: string, language: string) => Promise<LocalNewsModel[]>
 
   /**
    * Sets the local news and persists them.
    */
-  setLocalNews: (city: string, language: string, events: Array<LocalNewsModel>) => Promise<void>
+  setLocalNews: (city: string, language: string, events: LocalNewsModel[]) => Promise<void>
 
   /**
    * Returns the ResourceCache.

native/src/utils/DatabaseConnector.ts

@@ -54,7 +54,7 @@ type ContentCategoryJsonType = {
   thumbnail: string | null
   available_languages: Record<string, string>
   parent_path: string
-  children: Array<string>
+  children: string[]
   order: number
   organization: {
     name: string
@@ -279,7 +279,7 @@ class DatabaseConnector {
     this._storeMetaCities(metaData)
   }
 
-  async _deleteMetaOfCities(cities: Array<string>): Promise<void> {
+  async _deleteMetaOfCities(cities: string[]): Promise<void> {
     const metaCities = await this._loadMetaCities()
     cities.forEach(city => delete metaCities[city])
     await this._storeMetaCities(metaCities)
@@ -342,7 +342,7 @@ class DatabaseConnector {
     await this.writeFile(path, JSON.stringify(citiesMetaJson))
   }
 
-  async loadLastUsages(): Promise<Array<CityLastUsageType>> {
+  async loadLastUsages(): Promise<CityLastUsageType[]> {
     const metaData = await this._loadMetaCities()
     return map<MetaCitiesType, CityLastUsageType>(metaData, (value, key) => ({
       city: key,
@@ -437,7 +437,7 @@ class DatabaseConnector {
     return this.readFile(path, mapCategoriesJson)
   }
 
-  async storePois(pois: Array<PoiModel>, context: DatabaseContext): Promise<void> {
+  async storePois(pois: PoiModel[], context: DatabaseContext): Promise<void> {
     const jsonModels = pois.map(
       (poi: PoiModel): ContentPoiJsonType => ({
         path: poi.path,
@@ -484,7 +484,7 @@ class DatabaseConnector {
     await this.writeFile(this.getContentPath('pois', context), JSON.stringify(jsonModels))
   }
 
-  async loadPois(context: DatabaseContext): Promise<Array<PoiModel>> {
+  async loadPois(context: DatabaseContext): Promise<PoiModel[]> {
     const path = this.getContentPath('pois', context)
     const mapPoisJson = (json: ContentPoiJsonType[]) =>
       json.map(jsonObject => {
@@ -569,7 +569,7 @@ class DatabaseConnector {
     return this.readFile(path, mapLocalNewsJson)
   }
 
-  async storeCities(cities: Array<CityModel>): Promise<void> {
+  async storeCities(cities: CityModel[]): Promise<void> {
     const jsonModels = cities.map(
       (city: CityModel): ContentCityJsonType => ({
         name: city.name,
@@ -592,7 +592,7 @@ class DatabaseConnector {
     await this.writeFile(this.getCitiesPath(), JSON.stringify(jsonModels))
   }
 
-  async loadCities(): Promise<Array<CityModel>> {
+  async loadCities(): Promise<CityModel[]> {
     const path = this.getCitiesPath()
     const mapCityJson = (json: ContentCityJsonType[]) =>
       json.map(
@@ -619,7 +619,7 @@ class DatabaseConnector {
     return this.readFile(path, mapCityJson)
   }
 
-  async storeEvents(events: Array<EventModel>, context: DatabaseContext): Promise<void> {
+  async storeEvents(events: EventModel[], context: DatabaseContext): Promise<void> {
     const jsonModels = events.map(
       (event: EventModel): ContentEventJsonType => ({
         path: event.path,
@@ -663,7 +663,7 @@ class DatabaseConnector {
     await this.writeFile(this.getContentPath('events', context), JSON.stringify(jsonModels))
   }
 
-  async loadEvents(context: DatabaseContext): Promise<Array<EventModel>> {
+  async loadEvents(context: DatabaseContext): Promise<EventModel[]> {
     const path = this.getContentPath('events', context)
     const mapEventsJson = (json: ContentEventJsonType[]) =>
       json.map(jsonObject => {