doctl: pagination is 1 indexed, not 0 indexed #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #78 |
|
this |
|
@aybabtme clearly it is fragile because its broken |
| @@ -80,7 +80,7 @@ func PaginateResp(gen Generator) ([]interface{}, error) { | |||
| } | |||
|
|
|||
| // start with second page | |||
| for i := 1; i < lp; i++ { | |||
| for i := 2; i <= lp; i++ { | |||
There was a problem hiding this comment.
can you increment opt.Page++ instead? feels more obvious to me, since the :=2 here really just means "the page after what we just fetched"
jphines
force-pushed
the
jphines/storage/doctl-pagination
branch
from
64f8c16
to
735a754
Compare
|
|
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the bug, but I'll let CI run the tests.
Essentially pagination is 1 indexed, and not 0 indexed. So we re-fetch the first page, but never fetch the second, getting a "second page" full of dupes.