Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctl: pagination is 1 indexed, not 0 indexed #79

Merged
merged 1 commit into from
May 23, 2016
Merged

doctl: pagination is 1 indexed, not 0 indexed #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions do/pagination.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func PaginateResp(gen Generator) ([]interface{}, error) {
fetchChan := make(chan int, maxFetchPages)

var wg sync.WaitGroup
for i := 0; i < 4; i++ {
for i := 0; i < maxFetchPages-1; i++ {
wg.Add(1)
go func() {
for page := range fetchChan {
Expand Down Expand Up @@ -80,8 +80,9 @@ func PaginateResp(gen Generator) ([]interface{}, error) {
}

// start with second page
for i := 1; i < lp; i++ {
fetchChan <- i
opt.Page++
for ; opt.Page <= lp; opt.Page++ {
fetchChan <- opt.Page
}
close(fetchChan)

Expand Down