Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatische Shacl-Validierung ergänzen #29

Closed
acka47 opened this issue Dec 12, 2023 · 0 comments · Fixed by #40
Closed

Automatische Shacl-Validierung ergänzen #29

acka47 opened this issue Dec 12, 2023 · 0 comments · Fixed by #40
Assignees
@sroertgen

Comments

@acka47
Copy link
Member

acka47 commented Dec 12, 2023

In #28 wurde ein Stand zum Review gegeben, der sich gar nicht mit SkoHub Vocabs bauen ließ. Heraugefunden habe ich das erst, nachdem ich den Code in einem neuen Branch ausgecheckt und einen Build getriggert habe. Wir könnten den Workflow konfortabler gestalten, wenn wir einen automatischen Test ergänzen würden, der bei jedem PR durchläuft und meldet, wenn es Probleme gibt. Dabei sollte auf den jeweils aktuellen Shapes in https://github.com/skohub-io/shapes/ zurückgegriffen werden.

Das wäre dann auch die Referenzimplementierung eines solchen Tests, die andere (z.B. ich) für weitere Vokabulare umsetzen könnten.
@acka47 acka47 moved this to 📋 Backlog in Metadatengruppe Dec 12, 2023
@acka47 acka47 mentioned this issue Jan 25, 2024
Open
@acka47 acka47 added this to SkoHub Mar 13, 2024
@acka47 acka47 moved this to Ready in SkoHub Mar 13, 2024
@acka47 acka47 mentioned this issue Mar 13, 2024
Open
@sroertgen sroertgen moved this from Ready to Working in SkoHub Mar 18, 2024
sroertgen added a commit that referenced this issue Mar 19, 2024
@sroertgen
Test GitHub Action #29
464b355
sroertgen added a commit that referenced this issue Mar 19, 2024
@sroertgen
Test validation of ttl file #29
9912319
@sroertgen sroertgen moved this from 📋 Backlog to 🏗 In progress in Metadatengruppe Mar 19, 2024
sroertgen added a commit that referenced this issue Mar 19, 2024
@sroertgen
Test validation for warnings and errors #29
cff5ed3
sroertgen added a commit that referenced this issue Mar 19, 2024
@sroertgen
Split warning and error validation #29
99583b3
sroertgen added a commit that referenced this issue Mar 19, 2024
@sroertgen
Use append redirect operator #29
9f44d24
sroertgen added a commit that referenced this issue Mar 19, 2024
@sroertgen
Name Jobs for better readability #29
891f558
@sroertgen sroertgen moved this from 🏗 In progress to 👀 In review in Metadatengruppe Mar 19, 2024
@sroertgen sroertgen linked a pull request Mar 19, 2024 that will close this issue
29 shacl #40
Merged
@sroertgen sroertgen moved this from Working to Review in SkoHub Mar 19, 2024
sroertgen added a commit that referenced this issue Mar 20, 2024
@sroertgen
Try out warning message #29
16238cd
sroertgen added a commit that referenced this issue Mar 20, 2024
@sroertgen
Change back to failing instead of warning message #29
3261bee 
See #40 (comment)
sroertgen added a commit that referenced this issue Mar 20, 2024
@sroertgen
29 shacl (#40)
e2b0e04 
* Test GitHub Action #29

* Test validation of ttl file #29

* Test validation for warnings and errors #29

* Split warning and error validation #29

* Use append redirect operator #29

* Name Jobs for better readability #29

* Try out warning message #29

* Change back to failing instead of warning message #29

See #40 (comment)
@github-project-automation github-project-automation bot moved this from Review to Done in SkoHub Mar 20, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Metadatengruppe Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sroertgen sroertgen

Labels
None yet
Projects
Metadatengruppe
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

29 shacl dini-ag-kim/hochschulfaechersystematik
2 participants
@acka47 @sroertgen