Skip to content

Commit

Permalink
Merge pull request #53 from dioptra-io/fix-caracal-build
Browse files Browse the repository at this point in the history
fix building issue with conan >2.0
  • Loading branch information
matthieugouel authored Mar 6, 2023
2 parents 18a50a3 + e7b714c commit a498cef
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.14.1
current_version = 0.14.3
commit = True
tag = True
message = release(project): {current_version} → {new_version}
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: cachix/install-nix-action@v18
- uses: cachix/install-nix-action@v20
- uses: cachix/cachix-action@v12
with:
name: ${{ secrets.CACHIX_NAME }}
Expand All @@ -36,7 +36,7 @@ jobs:
run: |
sudo apt update
sudo apt install --yes build-essential cmake gcovr ninja-build python3-pip
pip3 install conan
pip3 install "conan<2.0"
- name: Configure project
run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-fprofile-arcs -ftest-coverage -fsanitize=address -fsanitize=undefined" -DWITH_CONAN=ON -DWITH_TESTS=ON
- name: Build tests
Expand All @@ -56,7 +56,9 @@ jobs:
path: ~/.conan/data
key: ${{ runner.os }}-x86_64
- name: Install dependencies
run: brew install cmake conan gcovr ninja
run: brew install cmake gcovr ninja
- name: Install Conan
run: pip3 install "conan<2.0"
- name: Configure project (try 1/2)
run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-fprofile-arcs -ftest-coverage -fsanitize=address -fsanitize=undefined" -DWITH_CONAN=ON -DWITH_TESTS=ON
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.16)
project(caracal VERSION 0.14.1)
project(caracal VERSION 0.14.3)

# We have Find* modules in two places:
# - The build directory, for the libraries fetched by Conan
Expand Down
10 changes: 5 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
apt-get install --no-install-recommends --quiet --yes \
build-essential \
cmake \
ninja-build \
python3-pip && \
build-essential \
cmake \
ninja-build \
python3-pip && \
rm --force --recursive /var/lib/apt/lists/*

# hadolint ignore=DL3059
RUN python3 -m pip install --no-cache-dir build conan>=1.35
RUN python3 -m pip install --no-cache-dir build "conan>=1.35,<2.0"

WORKDIR /tmp
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
packages = {
caracal = pkgs.stdenv.mkDerivation {
pname = "caracal";
version = "0.14.1";
version = "0.14.3";
src = self;
nativeBuildInputs = [
pkgs.cmake
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools", "wheel", "cmake", "conan", "ninja", "scikit-build", "pybind11"]
requires = ["setuptools", "wheel", "cmake", "conan<2.0", "ninja", "scikit-build", "pybind11"]
build-backend = "setuptools.build_meta"

[tool.cibuildwheel]
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name="pycaracal",
version="0.14.1",
version="0.14.3",
author="Maxime Mouchet",
author_email="max@maxmouchet.com",
url="https://github.com/dioptra-io/caracal",
Expand Down

0 comments on commit a498cef

Please sign in to comment.