fix building issue with conan >2.0

[matthieugouel]

Since Feb. 2023, a new major version of Conan is out (see https://blog.conan.io/2023/02/22/Conan-2.0.html).
It seems to break the building of Caracal due to changes in configuration file handling AFAIK.

Example of failing here :

#24 16.72   ERROR: Error while parsing [options] in conanfile.txt
#24 16.72   Options should be specified as 'pkg/*:option=value'
#24 16.75   CMake Error at cmake/conan.cmake:638 (message):
#24 16.75     Conan install failed='1'
#24 16.75   Call Stack (most recent call first):
#24 16.75     CMakeLists.txt:42 (conan_cmake_install)
#24 16.75 

This PR enforces the building with Conan <2.0.
LMK if something else needs to be done.

[maxmouchet]

Nice! I had a fix locally but never pushed it 😅

Can you also constrain/pin the version there?

• https://github.com/dioptra-io/caracal/blob/main/.github/workflows/tests.yml#L39
• https://github.com/dioptra-io/caracal/blob/main/.github/workflows/tests.yml#L59

[maxmouchet]

One more thing, can you set cachix-action version to 20 to fix Nix build?

https://github.com/dioptra-io/caracal/blob/main/.github/workflows/tests.yml#L20
cachix/cachix-action#144

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (18a50a3) 80.26% compared to head (e7b714c) 80.42%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   80.26%   80.42%   +0.15%     
==========================================
  Files          25       25              
  Lines        1267     1267              
  Branches      758      758              
==========================================
+ Hits         1017     1019       +2     
  Misses        156      156              
+ Partials       94       92       -2     

Impacted Files	Coverage Δ
src/rate_limiter.cpp	74.07% <0.00%> (+3.70%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[maxmouchet]

Nvm, another action (cachix/install-nix-action@v20) must be used. I'll fix later.

[matthieugouel]

I resolved the issue in the test.yml GH Action workflow for linux and macos but I'm not familiar with Nix, could you point me out where to make the modification ?

[matthieugouel]

Nvm, another action (cachix/install-nix-action@v20) must be used. I'll fix later.

Ok, I'm gonna merge this one and create an issue for Nix build.
Thanks!

[matthieugouel]

Oh I see you already fixed it, thanks!

[maxmouchet]

Looks like macOS build is still broken though.

[matthieugouel]

FIxed for MacOS