Feature/i18n #814
Feature/i18n #814
Conversation
|
@lutangar @JalilArfaoui @christpet The extension is ready to be translated, if you want to check. Otherwise I have a little problem with semaphore which hasn't validated one of my commit |
src/locales/resources.ts
Outdated
| import fr from './fr'; | ||
| import en from './en'; | ||
|
|
||
| export default { |
Don't bother about this, ... happens sometimes. You kept the WIP flag on this, do you plan to keep working on this branch? Shall we merge it? |
|
Sorry i forgot to remove the flag, yes we can merge |
|
@lutangar it's done for me, do you want to merge ? |
|
🎉 This PR is included in version 3.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@JalilArfaoui I can't use Hook on class components so I use HOC instead |
|
@gregoirelacoste oh yes of course … I knew I was missing something obvious 😅 Thanks ! |
|
@gregoirelacoste just noticed this slight bug in the extension on the Firefox Staging, latest version 3.67.2: Bug description:
How to reproduce:
|
|
I have another one here @gregoirelacoste:
As you can see, it says "Demander une information ici" instead of the English translation This is on the Firefox staging version See also "Previsualiser" instead of "Preview"
|
|
It looks like all the headings of the extension are not translated:
|
|
One more:
In an English-language browser, the top menu in the "profiles" app is showing the French words |
it's linked to this issue : #852 |
closes #811 closes #793 closes #809