Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(i18n): title #871

Closed
gregoirelacoste opened this issue Mar 25, 2021 · 2 comments · Fixed by #873
Closed

Fix(i18n): title #871

gregoirelacoste opened this issue Mar 25, 2021 · 2 comments · Fixed by #873
Assignees
@gregoirelacoste
Labels
bug 🐞 released

Comments

@gregoirelacoste
Copy link
Member

Describe the bug
Some titles are not translated

To Reproduce

  1. see Feature/i18n #814 (comment)

Expected behavior
Titles display english text

Screenshots
see : #814 (comment)
@gregoirelacoste gregoirelacoste self-assigned this Mar 25, 2021
@gregoirelacoste
Copy link
Member Author

gregoirelacoste commented Mar 25, 2021 •
edited
Loading

@christpet could you send me the translation for these titles ? I will integrate them directly

  • Demander une information ici
  • Prévisualisation
  • Abonnements
  • Aide

gregoirelacoste added a commit that referenced this issue Mar 25, 2021
@gregoirelacoste
fix(i18n): t function on withTitle hoc #871
5aa2b9f
@gregoirelacoste gregoirelacoste mentioned this issue Mar 25, 2021
Merged
gregoirelacoste added a commit that referenced this issue Mar 25, 2021
@gregoirelacoste
fix(i18n): t function on withTitle hoc #871
9e53824
@christpet christpet removed their assignment Mar 25, 2021
gregoirelacoste added a commit that referenced this issue Mar 25, 2021
@gregoirelacoste
Merge pull request #873 from dis-moi/fix/i18n_titles
aaffc81 
fix(i18n): t function on withTitle hoc #871
bmenant added a commit that referenced this issue Mar 25, 2021
@bmenant
chore: release 3.67.3
d12f3fb 
## [3.67.3](v3.67.2...v3.67.3) (2021-03-25)

### Bug Fixes

* **i18n:** t function on withTitle hoc [#871](#871) ([9e53824](9e53824))
@bmenant
Copy link
Member

bmenant commented Mar 25, 2021

🎉 This issue has been resolved in version 3.67.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregoirelacoste gregoirelacoste

Labels
bug 🐞 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n): t function on withTitle hoc #871 dis-moi/extension
3 participants
@bmenant @christpet @gregoirelacoste