fix(i18n): t function on withTitle hoc #871 #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutangar
approved these changes
Mar 25, 2021
src/components/atoms/Button/AddNoticeButton/AddNoticeButton.tsx
Outdated
Show resolved
Hide resolved
christpet
suggested changes
Mar 25, 2021
ok, good news |
gregoirelacoste
force-pushed
the
fix/i18n_titles
branch
from
5aa2b9f to
9e53824
Compare
|
@christpet it's ok for you ? |
|
🎉 This PR is included in version 3.67.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@christpet can you correct my english translation ?
@lutangar i add t function on withTitle HOC. It translate all titles (profiles and extension) but use only extension namespace to refer words (i18n use "extension" NS as defaultNS). It's ok for you ?
closes #871