fix(GuildMemberUpdate): cache incoming members & use partials if enabled #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Nov 7, 2020
NotSugden
suggested changes
Nov 7, 2020
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
|
cc #4975 |
1 task
This was referenced Nov 8, 2020
kyranet
approved these changes
Nov 8, 2020
vladfrangu
reviewed
Nov 8, 2020
vladfrangu
approved these changes
Nov 8, 2020
iCrawl
approved these changes
Nov 20, 2020
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR ensures that the incoming member (update) data is always cached, even if the member was not cached.
If using partials, the guildMemberUpdate event will be emitted with a partial 'old' member.
If not using partials, the guildMemberAvailable event will be emitted.
I also added the guildMemberAvailable event doc string back, which was erroneously removed from the documentation some time ago. (See: f3cad81 )
This is not tested yet.
Status
Semantic versioning classification: