Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin @discordjs/ws version in discord.js #9533

Merged
merged 2 commits into from
May 7, 2023
Merged

chore(deps): pin @discordjs/ws version in discord.js #9533

merged 2 commits into from
May 7, 2023

Conversation

SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented May 7, 2023

Please describe the changes this PR makes and why it should be merged:
#9416 pinned the version of /rest in discord.js but /ws also had the node version bump and it's being used in discord.js, which is a breaking change

image

image

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner May 7, 2023 11:36
@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 7, 2023 11:40am
discord-js-guide ⬜️ Ignored (Inspect) May 7, 2023 11:40am

@Jiralite Jiralite added this to the discord.js 14.12 milestone May 7, 2023
@iCrawl
Copy link
Member

iCrawl commented May 7, 2023

A breaking change would be released as 0.9.x which would get updated with ^

@vladfrangu
Copy link
Member

A breaking change would be released as 0.9.x which would get updated with ^

Except it won't because 0ver

@iCrawl iCrawl merged commit 7ce6bb9 into discordjs:main May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants