fix time formatting error with different timezones #149
Conversation
discord/time.go
Outdated
| @@ -32,7 +32,7 @@ func (t *Time) UnmarshalJSON(data []byte) error { | |||
| return err | |||
| } | |||
|
|
|||
| t.Time = parsed | |||
| t.Time = parsed.UTC() | |||
There was a problem hiding this comment.
does discord always send time in UTC?
There was a problem hiding this comment.
it seems discord does not specify their timezone, because ISO8601 includes timezone information. I just added .UTC() to pass the test. .UTC() just changes timezone in time.Time instance, so the absolute time will not be changed.
There was a problem hiding this comment.
perhaps we should instead update the test?
discord/time.go
Outdated
| @@ -8,7 +8,7 @@ import ( | |||
| "github.com/disgoorg/disgo/json" | |||
| ) | |||
|
|
|||
| const TimeFormat = "2006-01-02T15:04:05+00:00" | |||
| const TimeFormat = "2006-01-02T15:04:05-07:00" | |||
There was a problem hiding this comment.
after reading a bit more about ISO 8601 it seems like time.RFC3339 should also work?
I'm not rly into this time shit so I appreciate the help
There was a problem hiding this comment.
I did some closer investigation and it seems like we can just use the std time.Time. So removing the custom time type should be the way to go
the only annoying thing the std lib does not is marshalling a time.IsZero() to null but we can work around that with the json.Nullable[T any] type
|
I have the needed changes laying around locally if you don't mind me pushing them into your pr |
|
I pushed them now as I'd like to get the changes out. Thank you tho! |
|
I'm so sorry I've been away for a long time because of the move! Thank you for finishing up all the things :) |
|
Sure 👍 |
Hello!
The timezone is not parsed with
+00:00format string atdiscord/time.go#11.This caused my embed message timestamp to display incorrectly.
So I changed it to support various timezone.
Please check this issue!
Thank you.