-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getRouteHash
concurrency safety
#160
Conversation
Since there is no lock for map reading and writing, panic seems to occur under concurrency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd be happier to not use sync.Map
with casting
instead use a sync.Mutex
Emmmm, I changed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides that small thingy looks good to me
remove `l.hashesMu = sync.Mutex{}` Co-authored-by: ToπSenpai <15636011+TopiSenpai@users.noreply.github.com>
I saw that |
ohh nevermind it should be there yes I thought this was in the constructor lol |
Ok. I add it. |
thank you! |
No description provided.