Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add role connections #219

Merged
merged 6 commits into from
Dec 15, 2022
Merged

add role connections #219

merged 6 commits into from
Dec 15, 2022

Conversation

sebm253
Copy link
Member

@sebm253 sebm253 commented Dec 8, 2022

@sebm253 sebm253 marked this pull request as ready for review December 12, 2022 17:33
@sebm253 sebm253 requested a review from topi314 December 12, 2022 17:33
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once I can actually test this I'll do a final review

discord/application_role_connection_metadata.go Outdated Show resolved Hide resolved
rest/applications.go Outdated Show resolved Hide resolved
@sebm253 sebm253 requested a review from topi314 December 13, 2022 06:23
…add new routes to oauth2 client & fix ApplicationRoleConnection metadata type
@sebm253
Copy link
Member Author

sebm253 commented Dec 14, 2022

this is missing the description field for roles.

@sebm253 sebm253 merged commit bb4c3d6 into development Dec 15, 2022
@sebm253 sebm253 deleted the patch/role-connections branch December 15, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants