-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primary branch name in CI configurations points to main
but main
was renamed to master
#369
Labels
bug
Something isn't working
Comments
This was referenced Sep 18, 2021
Great Analysis! Thx! The branch was named
I want to ignore the reason why |
Sounds good, thank you. I think #371 sufficiently addresses the issue in that case. Actions are running again! I'll close this out. |
blaggacao
pushed a commit
that referenced
this issue
Sep 20, 2021
`main` is no longer in use. See #369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
CI workflow configurations and documentation should reference the current primary branch. At this point in time, that is
master
, but ideallymaster
would be removed in favor of amain
branch as the primary branch on GitHub.Current Behavior
There are still a few references throughout the project to
main
, which appears to have been renamed tomaster
(see #368).The primary result of this is that CI workflows are not running upon pushes to
master
as they had been formain
.Possible Solution
Rename
master
tomain
if currently feasible.If not currently feasible, replace references to
main
withmaster
to reflect the repo's current state untilmaster
can be renamed tomain
in line with conventions and the previous state of the repo.Steps to Reproduce
Most notably
main
is left over in some CI configurations:https://github.com/divnix/devos/blob/a3b2bcf3d57be28c27119a44445cfdde38349cb9/.github/workflows/mdbook_docs.yml#L1-L6
https://github.com/divnix/devos/blob/a3b2bcf3d57be28c27119a44445cfdde38349cb9/.github/workflows/check.yml#L1-L7
main
is also referred to as the preferred base branch for pull requests in https://github.com/divnix/devos/blob/master/doc/CONTRIBUTING.mdContext
I'm guessing this explains not only why the live docs site is out of sync with
master
but also why checks and Cachix update workflows haven't been running.It might also be the cause of #363 since 079adc4 was the last commit to cause that workflow run.
The text was updated successfully, but these errors were encountered: