-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace references to flk
and core
with bud
and master
#370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two small fixup suggestion. Otherwise looks excellent!
Thank you for this unit of work!
doc/integrations/deploy.md
Outdated
@@ -40,7 +40,7 @@ And the private key to your user: | |||
|
|||
And run the deployment: | |||
```sh | |||
deploy "flk#hostName" --hostname host.example.com | |||
deploy "bud#hostName" --hostname host.example.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was/is not correct.
It would be deploy ".#hostName"
(assuming the user is at the root of the repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a82c828.
Also note that I changed this example to use single quotes since I know the hash character in the <dir>#<output>
format sometimes may cause shells to interpret the string as needing expansion (related to string replacement, I think?). I've run into this when running nix build ".#myHost"
in zsh at least.
doc/start/index.md
Outdated
|
||
cd flk | ||
cd bud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd devos
See: https://github.com/divnix/devos/blob/master/bud/get.bash
(defaults to devos
)
As mentioned in #370 it would not result in a directory called `bud`, as can be seen in the custom `get.bash` command where the directory name defaults to `devos`.
As mentioned in #370 it would not result in a directory called `bud`, as can be seen in the custom `get.bash` command where the directory name defaults to `devos`.
Fixes #366
Blocked by #369 — the docs cannot be updated until the docs workflow is running again. The site hasn't been built since last month despite other recent updates to docs on✅master
.