Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to actions that use recent Node.js #684

Closed
tgeoghegan opened this issue Oct 26, 2022 · 5 comments
Closed

Update to actions that use recent Node.js #684

tgeoghegan opened this issue Oct 26, 2022 · 5 comments

Comments

@tgeoghegan
Copy link
Contributor

On a recent run of ci-build, GitHub Actions posted a warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-rs/toolchain, arduino/setup-protoc

actions-rs/toolchain#219 tracks actions-rs/toolchain adopting a newer node.

arduino/setup-protoc#45 tracks arduino/setup-protoc adopting a newer node.

I believe we're blocked here until the two issues above are resolved. This might be a problem since actions-rs/toolchain doesn't seem to be maintained.

@tgeoghegan
Copy link
Contributor Author

#685 moves us off actions-rs/toolchain altogether.

tgeoghegan added a commit to divviup/libprio-rs that referenced this issue Oct 26, 2022
tgeoghegan added a commit to divviup/libprio-rs that referenced this issue Oct 26, 2022
@RainbowMango
Copy link

+1
Just echo the warning message here:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: 

arduino/setup-protoc

@RainbowMango
Copy link

cc the maintainer for help @divergentdave

@tgeoghegan
Copy link
Contributor Author

We're aware of the problem. We're blocked on either arduino/setup-protoc#45 being resolved or finding an alternate means of installing protoc in CI.

@divergentdave
Copy link
Collaborator

This was resolved in #1407, which removed our need for protoc. I spot checked each of our workflows, and we're not seeing these warnings anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants