Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dtolnay/rust-toolchain GitHub Action #345

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

tgeoghegan
Copy link
Contributor

@tgeoghegan tgeoghegan requested a review from a team as a code owner October 26, 2022 19:45
@@ -37,7 +37,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
uses: dtolnay/rust-toolchain@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second and third invocations should use the stable branch, as the v1 tag is stale.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also forgot to strip off some obsolete arguments that aren't used by dtolnay/rust-toolchain@v1.

@tgeoghegan tgeoghegan force-pushed the timg/dtolnay-rust-toolchain-action branch from 42b5fb6 to 632e769 Compare October 26, 2022 20:20
@tgeoghegan tgeoghegan merged commit 45951f3 into main Oct 26, 2022
@tgeoghegan tgeoghegan deleted the timg/dtolnay-rust-toolchain-action branch October 26, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants