Skip to content

Windows code signing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 11, 2024
Merged

Windows code signing #8

merged 20 commits into from
Apr 11, 2024

Conversation

dylanhand
Copy link
Contributor

@dylanhand dylanhand commented Feb 28, 2024

Integrates SSL.com's eSigner for automated windows code signing.

https://github.com/divvun/maintenance2023/issues/37

Theory is that it's not downloading the specified branch of this repo because it's already downloaded the `main` branch earlier so it's in the list of already-downloaded repos. Hopefully specifying branch in the *first* reference to this GHA repo will fix the issue. If it does, this needs to be refactored to be less esoteric.
When using the same gha, the branch is only considered on the first call to that gha url.
This reverts commit 93fec9f.
@dylanhand dylanhand force-pushed the windows-codesign branch 3 times, most recently from 0fcee95 to e72d607 Compare March 1, 2024 04:21
* Try making branches more robust

Change action_path and log

* Attempt to fix allowing multiple branches for gha

* Call new test action for faster testing

* Revert "Attempt to fix allowing multiple branches for gha"

This reverts commit 6b14efa.

* Revert "Try making branches more robust"

This reverts commit cc3aca2.

* Attempt to allow using github actions from different branches

* Specify branch from within GithubAction as we discussed

* Yes, here too

* Gotta do this lil guy from a branch as well now

* Remove test action
@dylanhand dylanhand changed the title Windows codesigning Windows code signing Apr 11, 2024
@dylanhand dylanhand marked this pull request as ready for review April 11, 2024 01:16
@dylanhand dylanhand merged commit 1209cf2 into main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant