-
Notifications
You must be signed in to change notification settings - Fork 0
Better taskcluster-gha
branching
#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhand
added a commit
that referenced
this pull request
Apr 11, 2024
* Add codesign step to lang-task and temporarily disable deploy * Try another way to use taskcluster-gha branch * Try using branch another way * Make sure using a branch is working * Oh man if this makes the branch work Theory is that it's not downloading the specified branch of this repo because it's already downloaded the `main` branch earlier so it's in the list of already-downloaded repos. Hopefully specifying branch in the *first* reference to this GHA repo will fix the issue. If it does, this needs to be refactored to be less esoteric. * See what it looks like on the other side * Revert "See what it looks like on the other side" This reverts commit 6667082. * Remove extra branch call When using the same gha, the branch is only considered on the first call to that gha url. * Running out of ideas * Revert "Running out of ideas" This reverts commit 6275874. * Going crazy * Revert "Going crazy" This reverts commit 93fec9f. * See if this branch breaks Mac builds * Revert "See if this branch breaks Mac builds" This reverts commit bd7d551. * Try sending signed output to deploy action * Better `taskcluster-gha` branching (#9) * Try making branches more robust Change action_path and log * Attempt to fix allowing multiple branches for gha * Call new test action for faster testing * Revert "Attempt to fix allowing multiple branches for gha" This reverts commit 6b14efa. * Revert "Try making branches more robust" This reverts commit cc3aca2. * Attempt to allow using github actions from different branches * Specify branch from within GithubAction as we discussed * Yes, here too * Gotta do this lil guy from a branch as well now * Remove test action * Add instructions for developing using branches * Add codesign step to keyboard task * Forgot to point to branch * Remove prints and branch references
dylanhand
added a commit
that referenced
this pull request
Apr 11, 2024
* Try making branches more robust Change action_path and log * Attempt to fix allowing multiple branches for gha * Call new test action for faster testing * Revert "Attempt to fix allowing multiple branches for gha" This reverts commit 6b14efa. * Revert "Try making branches more robust" This reverts commit cc3aca2. * Attempt to allow using github actions from different branches * Specify branch from within GithubAction as we discussed * Yes, here too * Gotta do this lil guy from a branch as well now * Remove test action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve using branches with
taskcluster-gha
.Currently it's possible to use a branch, but it's a bit of a hack and only works if the branch is specified in the very first call to a given taskcluster-gha repo.
This PR makes it possible to specify a branch on a per-gha call basis. This means multiple branches of the same
taskcluster-gha
repo may be used at the same time.Usage looks like this: