fix: directory listing with svg image #1470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa385bd removed the _view suffix to url name
fsbraun
reviewed
May 18, 2024
| @@ -139,7 +139,7 @@ | |||
| </td> | |||
| <td class="column-action"> | |||
| {% if file.canonical_url %} | |||
| <a href="{% if 'svg' in file.mime_type %}{% url 'admin:filer_image_expand_view' file.pk %}{% else %}{{ file.canonical_url }}{% endif %}" | |||
| <a href="{% if 'svg' in file.mime_type %}{% url 'admin:filer_image_expand' file.pk %}{% else %}{{ file.canonical_url }}{% endif %}" | |||
There was a problem hiding this comment.
Well spotted!
I would like to check if this also works for a custom image model.
fsbraun
added a commit
to fsbraun/django-filer
that referenced
this pull request
May 19, 2024
4 tasks
|
@fabien-michel I will close the PR in favour of #1471 : You found a second bug, which leads the corrected reverse name to fail of the Image model is swapped out. Thank you for bringing this up! I'd appreciate if you took a look at #1471 and gave me some feedback! |
|
#1471 seems to also fix the directory listing containing svg file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fa385bd2b4b3022f54499bbb3c603d463f4baf2e removed the
_viewsuffix from url nameRelated resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.