Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File expand url incorrect and worked not with custom image models #1471

Merged
merged 18 commits into from
May 21, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 19, 2024

Description

Fixes #1470:

fa385bd2b4b3022f54499bbb3c603d463f4baf2e removed the _view suffix from url name leading to an empty link.

Also, if the Image model is replaced by a custom model, the reverse name changes, too.

This PR moves the generation of the admin urls to the BaseImage model where the other admin urls are generated, sucha as get_admin_change_url etc.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from jrief May 19, 2024 14:18
tox.ini Outdated Show resolved Hide resolved
Co-authored-by: Mark Walker <theshow@gmail.com>
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (0402d66) to head (4ca60a5).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
- Coverage   77.05%   77.03%   -0.03%     
==========================================
  Files          75       75              
  Lines        3544     3549       +5     
  Branches      508      570      +62     
==========================================
+ Hits         2731     2734       +3     
- Misses        653      654       +1     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member Author

fsbraun commented May 20, 2024

@marksweb Oh dear, I fixed the typo in tox.ini.

@fsbraun fsbraun merged commit c8af44a into django-cms:master May 21, 2024
25 of 26 checks passed
This was referenced Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants