-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: File expand url incorrect and worked not with custom image models #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
marksweb
requested changes
May 19, 2024
Co-authored-by: Mark Walker <theshow@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
- Coverage 77.05% 77.03% -0.03%
==========================================
Files 75 75
Lines 3544 3549 +5
Branches 508 570 +62
==========================================
+ Hits 2731 2734 +3
- Misses 653 654 +1
- Partials 160 161 +1 ☔ View full report in Codecov by Sentry. |
@marksweb Oh dear, I fixed the typo in |
jrief
approved these changes
May 21, 2024
This was referenced Jul 15, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1470:
fa385bd2b4b3022f54499bbb3c603d463f4baf2e removed the
_view
suffix from url name leading to an empty link.Also, if the
Image
model is replaced by a custom model, the reverse name changes, too.This PR moves the generation of the admin urls to the
BaseImage
model where the other admin urls are generated, sucha asget_admin_change_url
etc.Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.