-
Notifications
You must be signed in to change notification settings - Fork 300
Use extra requires to seperate optional features django-filter and polymorphic #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@sliverc I've been staring at this for a bit... One issue is that I want to have the following extra-requires but one of them has it's own Django version constraints:
I'm not sure if setup.py's |
Fixes django-json-api#674 Currently only django-filter and django-polymorphic use the extra_requires definition.
Fixes django-json-api#674 Currently only django-filter and django-polymorphic use the extra_requires definition.
Fixes django-json-api#674 Currently only django-filter and django-polymorphic use the extra_requires definition.
Fixes #674 Currently only django-filter and django-polymorphic use the extra_requires definition.
The optional features (Polymorphic and Django filter) should define their dependencies as extra.
Currently this is only done as test requires but actual users won't have enforced minimum requirements.
Once this is done a user can simply add following into their requirements to properly activate an optional feature:
see
https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies
The text was updated successfully, but these errors were encountered: