Skip to content

Use extra requires to separate optional features #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 3, 2019

Fixes #674

Currently only django-filter and django-polymorphic use the extra_requires definition.
PR includes some small on the fly documentation changes.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Fixes django-json-api#674

Currently only django-filter and django-polymorphic use the extra_requires
definition.
@sliverc sliverc marked this pull request as ready for review October 3, 2019 16:25
@sliverc sliverc requested a review from n2ygk October 3, 2019 16:27
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing the extra-require stuff!

@n2ygk n2ygk merged commit 8271b15 into django-json-api:master Oct 3, 2019
@sliverc sliverc deleted the extra_requires branch October 4, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use extra requires to seperate optional features django-filter and polymorphic
2 participants