Skip to content

Remove pytest runner to run test #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 3, 2019

Description of the Change

pytest was already used when running test manually but not when running tox or travis. Partially addressing #635

I want to keep the PRs small so for now removed twine dependency and django-filter resp. django-polymorphic dependency definition. Those will be reintroduced again later when introducing extra_requires and splitting up dependencies as in DRF.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 3, 2019 11:17
This was the case already when running test manually but
not when running tox or travis
@sliverc sliverc force-pushed the remove_pytest_runner branch from 88e2306 to 70bbb0e Compare October 3, 2019 11:17
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clutter reduction.

@n2ygk n2ygk merged commit b3cacb7 into django-json-api:master Oct 3, 2019
sliverc added a commit to sliverc/django-rest-framework-json-api that referenced this pull request Oct 12, 2019
@sliverc sliverc mentioned this pull request Oct 12, 2019
5 tasks
n2ygk pushed a commit that referenced this pull request Oct 12, 2019
This got mistakenly deleted in #714
@sliverc sliverc deleted the remove_pytest_runner branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants