Skip to content

Introduce wheel in setup.py again #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2019
Merged

Introduce wheel in setup.py again #723

merged 1 commit into from
Oct 12, 2019

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 12, 2019

This got mistakenly deleted in #714

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 12, 2019 10:26
@sliverc sliverc mentioned this pull request Oct 12, 2019
Merged
5 tasks
@codecov
Copy link

codecov bot commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          54       54           
  Lines        2742     2742           
=======================================
  Hits         2662     2662           
  Misses         80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca25e1...d8054c4. Read the comment docs.

n2ygk
n2ygk approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 83b6815 into django-json-api:master Oct 12, 2019
@sliverc sliverc deleted the introduce_wheel branch December 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @n2ygk