Skip to content

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Dec 21, 2021

Fix #1049.

Description of the Change

This will fix RTD installing conflicting Django versions.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

This will fix RTD installing conflicting Django versions.
@jezdez jezdez closed this Dec 21, 2021
@jezdez jezdez reopened this Dec 21, 2021
@jezdez
Copy link
Contributor Author

jezdez commented Dec 21, 2021

@n2ygk I've also enabled Read The Docs pull request integration so it shows the documentation build status here.

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (2909e55) to head (3f96bd5).
Report is 226 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1050   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          31       31           
  Lines        1756     1756           
=======================================
  Hits         1697     1697           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jezdez
Copy link
Contributor Author

jezdez commented Dec 21, 2021

If you click on the "Details" link next to the new "docs/readthedocs.org:django-oauth-toolkit" status check, it'll go to the PR-specific docs build. https://django-oauth-toolkit--1050.org.readthedocs.build/en/1050/

@jezdez jezdez requested a review from n2ygk December 21, 2021 12:38
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks!

I had noticed the pinned django version as well in #1049 but this is much better.

@n2ygk n2ygk added this to the 1.6.1 milestone Dec 21, 2021
@n2ygk n2ygk merged commit f338975 into master Dec 21, 2021
@n2ygk n2ygk deleted the docs-requirements branch December 21, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants