Fix conflict with existing add_foreign_key method (#1) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhofer
reviewed
Jul 30, 2017
| @@ -222,7 +222,7 @@ def unique_index_name(name, *partition_key_values) | |||
| # | |||
| def add_references_to_partition_table(*partition_key_values) | |||
| configurator.foreign_keys(*partition_key_values).each do |foreign_key| | |||
| add_foreign_key(partition_table_name(*partition_key_values), | |||
| add_foreign_key_constraint(partition_table_name(*partition_key_values), | |||
There was a problem hiding this comment.
Style comment: Would you mind fixing the indents of rest of the arguments being passed in in the next few lines?
dkhofer
reviewed
Jul 30, 2017
| @@ -281,7 +281,7 @@ def unique_index_name(name, *partition_key_values) | |||
| # | |||
| def add_references_to_partition_table(*partition_key_values) | |||
| configurator.foreign_keys(*partition_key_values).each do |foreign_key| | |||
| add_foreign_key(partition_table_name(*partition_key_values), | |||
| add_foreign_key_constraint(partition_table_name(*partition_key_values), | |||
| foreign_key.referencing_field, | |||
There was a problem hiding this comment.
Same comment as above, can you fix the indents here?
|
Couple style comments, otherwise looks good. |
hartsick
added a commit
to meedan/partitioned
that referenced
this pull request
Apr 20, 2023
Previously this was causing an error because ActiveRecord has a add_foreign_key method with a different signature. This solution was submitted by someone else in a PR at dkhofer#6, but was left unmerged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.