Skip to content

[WIP] Fix #328 - Add check for trailing whitespace#448

Closed
wilzbach wants to merge 1 commit intodlang-community:masterfrom
wilzbach:trailing_whitespace2
Closed

[WIP] Fix #328 - Add check for trailing whitespace#448
wilzbach wants to merge 1 commit intodlang-community:masterfrom
wilzbach:trailing_whitespace2

Conversation

@wilzbach
Copy link
Member

@wilzbach wilzbach commented Jun 12, 2017

I made the trailing whitespace inclusion at the lexer optin, s.t. you only pay for it when the trailing whitespace check is activated.
However, there's still no whitespace token stream.
Is libdparse popping them away?

For reference, it currently prints:

Include whitespace
typevoid line: 2
typeidentifier line: 2
type( line: 2
type) line: 2
type{ line: 2
type} line: 2
typevoid line: 5
typeidentifier line: 5
type( line: 5
type) line: 5
type{ line: 5
type} line: 5

@wilzbach wilzbach force-pushed the trailing_whitespace2 branch from b73cb56 to 7e73c74 Compare June 19, 2017 13:45
@wilzbach
Copy link
Member Author

Rebased.

@wilzbach
Copy link
Member Author

However, there's still no whitespace token stream.
Is libdparse popping them away?

Yup, getTokensForParser overwrites its given LexerConfig:
dlang-community/libdparse#149

@ghost ghost added the has conflicts label Aug 19, 2017
@ghost
Copy link

ghost commented Dec 20, 2018

I'm doing a bit of cleanup and close this since it's been abandoned.

@ghost ghost closed this Dec 20, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant