Explain Dlang-Bot's cross for references#124
Merged
PetarKirov merged 1 commit intomasterfrom Jul 5, 2017
Merged
Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
PetarKirov
approved these changes
Jul 5, 2017
Member
|
Good effort, but I doubt many people are going to sit down and read the documentation. I think UI changes would be more effective. The table is a little cryptic, maybe a bullet list in plain English would be better, e.g.:
|
wilzbach
added a commit
to wilzbach/dlang-bot
that referenced
this pull request
Jul 7, 2017
People repeatedly have shown problems to recognize that a cross (✗) means that the PR won't be automatically closed. While this has been documented in dlang#124, the best solution is to directly display the meaning on the Bot's comment.
wilzbach
added a commit
to wilzbach/dlang-bot
that referenced
this pull request
Jul 7, 2017
People repeatedly have shown problems to recognize that a cross (✗) means that the PR won't be automatically closed (and shown) as part of the changelog. While this has been documented in dlang#124, the best solution is to directly display the meaning on the Bot's comment.
Contributor
Author
The table has been there for a long and been done by @MartinNowak, so I don't want to change this without his approval (and I actually like the table), but there's a quick fix: |
Member
|
I also like the table, FWIW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From dlang/phobos#5543