Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
People repeatedly have shown problems to recognize that a cross (✗) means that the PR won't be automatically closed (and shown) as part of the changelog. While this has been documented in dlang#124, the best solution is to directly display the meaning on the Bot's comment.
PetarKirov
approved these changes
Jul 7, 2017
Contributor
Author
|
https://issues.dlang.org/show_bug.cgi?id=17614 starts to get annoying 😢 |
Contributor
Author
|
Deploying this manually then and let's see whether it helps people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People repeatedly have shown problems to recognize that a cross (✗)
means that the PR won't be automatically closed (and shown as part of the changelog).
While this has been documented in #124, the best solution is to directly display the meaning
on the Bot's comment.
Follow-up to #124 (comment)